CJM-97211 Introduce xdm-schema for message-rendering-context dataset #1977
Conversation
| "type": "object", | ||
| "title": "Message Details", | ||
| "description": "Contains the specific content details for the message, varying by channel (e.g., email or SMS).", | ||
| "oneOf": [ |
There was a problem hiding this comment.
I am not sure if oneOf will work. What are you expecting the validator to validate?
| "title": "Message Details", | ||
| "description": "Contains the specific content details for the message, varying by channel (e.g., email or SMS).", | ||
| "oneOf": [ | ||
| { |
There was a problem hiding this comment.
The structure of this JSON schema does not look right.
|
@anandphatak Would you please take a look at this PR? |
|
@himanshi2010 there are still some issues with the PR. My comments above for "allOf" are not addressed. Please setup a meeting to discuss. |
| "title": "Email Metadata", | ||
| "description": "Metadata specific to email delivery", | ||
| "properties": { | ||
| "https://ns.adobe.com/experience/customerJourneyManagement/messageDeliveryMetadata/emailMetadata/recipient": { |
There was a problem hiding this comment.
Please change the field name from https://ns.adobe.com/experience/customerJourneyManagement/messageDeliveryMetadata/emailMetadata/recipient to xdm:recipient.
(Essentially, remove the namespace https://ns.adobe.com/experience/customerJourneyManagement/messageDeliveryMetadata/emailMetadata from all child fields nested under parent field https://ns.adobe.com/experience/customerJourneyManagement/messageDeliveryMetadata/emailMetadata defined at line #19. Do this to the rest of the fields.
| "https://ns.adobe.com/experience/customerJourneyManagement/messageDeliveryMetadata/emailMetadata/recipient": { | ||
| "type": "object", | ||
| "properties": { | ||
| "https://ns.adobe.com/experience/customerJourneyManagement/messageDeliveryMetadata/emailMetadata/recipient/email": { |
There was a problem hiding this comment.
As note above please change the field name from https://ns.adobe.com/experience/customerJourneyManagement/messageDeliveryMetadata/emailMetadata/recipient/email to xdm:email.
| "format": "email", | ||
| "description": "Recipient's email address" | ||
| }, | ||
| "https://ns.adobe.com/experience/customerJourneyManagement/messageDeliveryMetadata/emailMetadata/recipient/name": { |
There was a problem hiding this comment.
Change from https://ns.adobe.com/experience/customerJourneyManagement/messageDeliveryMetadata/emailMetadata/recipient/name to xdm:name. And so on...
| } | ||
| }, | ||
| "required": [ | ||
| "https://ns.adobe.com/experience/customerJourneyManagement/messageDeliveryMetadata/emailMetadata/recipient/email" |
| "$ref": "#/definitions/messageDeliveryMetadata" | ||
| } | ||
| ], | ||
| "meta:status": "stable" |
There was a problem hiding this comment.
I will recommend it to keep "meta:status": "experimental" until this field group is tested and stabilized. Keeping it "experimental" marks it as beta, and is only available to limited number of IMS Orgs.
| "title": "Email Channel Content", | ||
| "description": "Email-specific rendered content", | ||
| "properties": { | ||
| "https://ns.adobe.com/experience/customerJourneyManagement/messageRenderedContent/emailContent/subject": { |
There was a problem hiding this comment.
Same comment as before for using field names without namespace https://ns.adobe.com/experience/customerJourneyManagement/messageRenderedContent/emailContent
| "$ref": "#/definitions/messageRenderedContent" | ||
| } | ||
| ], | ||
| "meta:status": "stable" |
There was a problem hiding this comment.
Recommend "experimental"
| "$ref": "#/definitions/messageRenderingMetadata" | ||
| } | ||
| ], | ||
| "meta:status": "stable" |
Introduced new field group schemas for Message Rendered Content, Rendering Metadata and Delivery Metadata of the communications going out of the AJO to provide the message-export functionality to the customers.
Wiki: https://wiki.corp.adobe.com/display/CJM/Message+Export+in+AJO